Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended cpp_info model object to new components concept #5242

Closed
wants to merge 52 commits into from
Closed

Extended cpp_info model object to new components concept #5242

wants to merge 52 commits into from

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented May 28, 2019 •
edited
Loading

Changelog: Feature: Extended cpp_info model to support different components
Docs: missing

Tasks:

  • 1. Add tests for cpp_info.system_deps
  • 2. Include a property in cpp_info to get keys of the components it has so it can be iterated
  • 3. Does cpp_info.exes makes sense when having components that are modeling them? Maybe apply the same policy used for cpp_info.libs (not allowed to set values if components are already in use)
  • 4. Is the above case check at conanfile load time? Make a test

@danimtb danimtb added this to the 1.16 milestone May 28, 2019
@lasote lasote removed this from the 1.16 milestone May 28, 2019
@jgsogo jgsogo mentioned this pull request Jun 12, 2019
Closed
This was referenced Jun 17, 2019
Closed
Closed
lasote
lasote suggested changes Jun 21, 2019
View reviewed changes
conans/model/build_info.py Show resolved Hide resolved
conans/model/build_info.py Outdated Show resolved Hide resolved
conans/model/build_info.py Show resolved Hide resolved
conans/model/build_info.py Show resolved Hide resolved
conans/model/build_info.py Show resolved Hide resolved
lasote
lasote suggested changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check for loops also. The code could be easier.

conans/model/build_info.py Outdated Show resolved Hide resolved
@lasote
Copy link
Contributor

lasote commented Jun 25, 2019

I've opened a PR here: danimtb#4
I think it can be done much easier. It is not needed to be that specific in the loops or missing components because the graph will be tiny, just avoid a bad crash or infinite loop.

@danimtb danimtb added this to the 1.17 milestone Jun 25, 2019
@lasote
Copy link
Contributor

lasote commented Jun 25, 2019

Docs

@lasote lasote removed this from the 1.17 milestone Jul 1, 2019
@danimtb danimtb mentioned this pull request Jul 1, 2019
Closed
@danimtb
Copy link
Member Author

danimtb commented Jul 9, 2019

This PR has evolved into the complete solution proposed in #5408. Please review the new implementation there.

@lasote
Copy link
Contributor

lasote commented Jul 12, 2019

Then I prefer to close this.

@lasote lasote closed this Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded left review comments

@lasote lasote lasote requested changes

@jgsogo jgsogo jgsogo left review comments

@SSE4 SSE4 SSE4 left review comments

Assignees

@lasote lasote

Labels
stage: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cppinfo improvements: components, exe, system deps...
5 participants
@danimtb @lasote @SSE4 @jgsogo @memsharded